This repository was archived by the owner on Aug 31, 2023. It is now read-only.
Repository navigation
Merged
Conversation
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
noDuplicateCasenoDuplicateCase
ematipico
reviewed
Jul 19, 2023
| /// let b = JsSyntaxToken::new_detached(JsSyntaxKind::CONST_KW, "const", [], []); | ||
| /// assert!(inner_text(&a) != inner_text(&b)); | ||
| /// ``` | ||
| pub fn inner_text(token: &JsSyntaxToken) -> &str { |
Contributor
There was a problem hiding this comment.
Two questions:
- we have some
inner_textfunctions already, weren't they sufficient? - why did you implement it as a function not inside as
implfor syntax tokens?
Contributor
Author
There was a problem hiding this comment.
This is JS-spêcific, while SyntaxToken is more general. It is not possible to write an impl on a type-alias such as JsSyntaxToken?
Which inner_text do you refer to?
Contributor
There was a problem hiding this comment.
We have a bunch of them: https://github.com/search?q=repo%3Arome%2Ftools+%22inner_string_text%22&type=code
So maybe there is some overlap, and if there isn't we should choose e better name to avoid confusion. Their names are very similar
This was referenced Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4706
Test Plan
Regression test included.