8000 refactor(rome_js_analyze): handle string literal names in useNamingCo… by Conaclos · Pull Request #4698 · rome/tools · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

Repository navigation

refactor(rome_js_analyze): handle string literal names in useNamingCo… - #4698

Merged
Conaclos merged 1 commit into
rome:mainfrom
Conaclos:useNamingConvention_handleStringLiteral
Jul 14, 2023
Merged

refactor(rome_js_analyze): handle string literal names in useNamingCo…#4698
Conaclos merged 1 commit into
rome:mainfrom
Conaclos:useNamingConvention_handleStringLiteral

Conversation

@Conaclos
@Conaclos Conaclos commented Jul 14, 2023
Copy link
Copy Markdown
Contributor

Summary

This PR improves useNamingConvention by handling string literal names. String literal names that are not identifiers are still ignored.

The following code is now handled:

class A {
  "Y" = 0
}

Test Plan

A new test is included.

@netlify
netlify Bot commented Jul 14, 2023 •
edited
Loading
Copy link
Copy Markdown

✅ Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 146f5d5
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64b135a13b7cbb0008895ce0

@github-actions github-actions Bot added the A-Linter Area: linter label Jul 14, 2023
@Conaclos
Conaclos merged commit 8234b5f into rome:main Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ematipico ematipico ematipico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Linter Area: linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Conaclos @ematipico
0