This repository was archived by the owner on Aug 31, 2023. It is now read-only.
Repository navigation
feat(rome_cli): exit with error if there are warnings - #4676
Merged
Merged
Conversation
✅ Deploy Preview for docs-rometools canceled.
|
ematipico
force-pushed
the
feat/exit-error-on-warnings
branch
from
July 10, 2023 08:03
bc77b02 to
6642890
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4552
Add a new
--error-on-warnings, to instruct the CLI to exit with an error code if there are at least warnings emitted.I took the opportunity to normalize the max default diagnostics across the board. I was not too fond of the fact that we had different defaults based on the command, which was impossible to document correctly.
Test Plan
Added new test cases.