This repository was archived by the owner on Aug 31, 2023. It is now read-only.
Repository navigation
feat(rome_service): add extends functionality - #4572
Merged
Merged
Conversation
✅ Deploy Preview for docs-rometools canceled.
|
denbezrukov
reviewed
Jun 15, 2023
ematipico
force-pushed
the
feat/configuration-extends
branch
from
June 17, 2023 13:04
bc82d12 to
1f7ec40
Compare
ematipico
force-pushed
the
feat/configuration-extends
branch
from
June 19, 2023 07:44
024a1a6 to
1fd1df2
Compare
ematipico
force-pushed
the
feat/configuration-extends
branch
from
June 22, 2023 10:08
1fd1df2 to
87f3f2c
Compare
ematipico
force-pushed
the
feat/configuration-extends
branch
5 times, most recently
from
June 22, 2023 10:56
d9c670a to
a4e9082
Compare
ematipico
marked this pull request as ready for review
June 22, 2023 11:01
ematipico
force-pushed
the
feat/configuration-extends
branch
from
June 23, 2023 14:05
a4e9082 to
2171857
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4038
This PR introduces breaking changes, mainly how the CLI handles broken configurations.
Before, a broken configuration would have resulted in warnings and Rome applying its defaults for the broken sections. I realised that while this is "cool", this isn't ideal for users because this would result in the following:
That's a breaking change.
Plus, now the
rome checkcommand shows diagnostics that belong to the formatter too.Test Plan
Added some test cases
Changelog
Documentation