8000 refactor(rome_js_analyze): enhance `useDefaultParameterLast` by Conaclos · Pull Request #4577 · rome/tools · GitHub
[go: up one dir, main page]

Skip to content 8000
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_js_analyze): enhance useDefaultParameterLast - #4577

Merged
Conaclos merged 1 commit into
rome:mainfrom
Conaclos:enhance-use-default-parameter-last
Jun 17, 2023
Merged

Conaclos merged 1 commit into
rome:mainfrom
Conaclos:enhance-use-default-parameter-last

Conversation

@Conaclos
Copy link
Copy Markdown
Contributor

Summary

This PR improves the code action and the diagnostic message of useDefaultParameterLast.

Test Plan

New test included.

Changelog

No need.

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
netlify Bot commented Jun 16, 2023 •
Copy link
Copy Markdown

✅ Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit e657754
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/648c653c2798150007929062

@github-actions github-actions Bot added A-Linter Area: linter A-Project Area: project configuration and loading labels Jun 16, 2023
@ematipico ematipico left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe any change is worth tracking. Even a "made the error message better" sort of message is a good message

@Conaclos
Conaclos merged commit 6250b02 into rome:main Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-Linter Area: linter A-Project Area: project configuration and loading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0