Repository navigation
Let the platform add the library prefix and drop the CNPM packaging - #4
Open
s-tokmakov-rogii wants to merge 2 commits into
Open
s-tokmakov-rogii wants to merge 2 commits into
s-tokmakov-rogii wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PREFIX ""), so the Linux library wasANN.soinstead oflibANN.so, the name of the original ANN build and the one the platform expects. The Windows names (ANN.dll,ANN.lib) do not change.rogii/folder is removed: it held only the CNPM packaging (build scripts,package.cmake, the toolchain package descriptions and the Jenkins environment). The library is packaged by the Conan recipe in 3rd_party/ANN on GitLab; the CNPM packages published so far stay on the server.