8000 docs/17: approved — the owner's answers to §17.8 (missed by #136's merge) by rleibman · Pull Request #139 · rleibman/thicket · GitHub
[go: up one dir, main page]

Skip to content

docs/17: approved — the owner's answers to §17.8 (missed by #136's merge) - #139

Merged
rleibman merged 1 commit into
mainfrom
docs/camera-preview-answers
Nov 2, 2026
Merged

rleibman merged 1 commit into
mainfrom
docs/camera-preview-answers

Conversation

@rleibman
@rleibman rleibman commented Nov 2, 2026
Copy link
Copy Markdown
Owner

#136 merged without its last commit (c16eccf), which recorded the owner's answers. This is that commit on main:

  • docs/decisions.md: a 2026-11-01 entry — the owner took every recommendation in §17.8 (embedding point; GTK Unavailable first; macOS built; no virtual camera yet; v1 = preview, facing, still capture) and the order of work.
  • docs/17: status "approved"; §17.2/§17.3/§17.8 marked decided; §17.7 puts -apple before -gtk.
  • docs/16 item 6 points to the approved design.

Docs only; one conflict on the cherry-pick (the decision log's top, both entries kept).

🤖 Generated with Claude Code

Embedding point (Element.Platform), GTK Unavailable first, macOS built, no
virtual camera yet, v1 = preview + facing + still capture. Decision log entry;
§17.7's order puts -apple before -gtk. Docs only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rleibman
rleibman requested a balanced review from Copilot November 2, 2026 01:39
@rleibman
rleibman merged commit cea7858 into main Nov 2, 2026
3 checks passed
Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a clean, internally consistent docs-only re-application of a lost commit with all cross-references resolving and no outstanding issues found.

No open issues 🎉

What changed in this PR

This documentation-only PR restores commit c16eccf, which was dropped when #136 was merged. It records the owner's answers to the open questions in the live-camera-preview design (docs/17-camera-preview.md §17.8), marking that design approved and propagating the decision into the decision log and the tier-3 roadmap note.

Changes:

  • Adds a 2026-11-01 decision-log entry capturing that the owner accepted every §17.8 recommendation (embedding point via Element.Platform, GTK Unavailable first, macOS built, no CI virtual camera, v1 = preview/facing/still-capture) plus the agreed order of work.
  • Updates docs/17 status to "approved", marks §17.2/§17.3/§17.8 as decided, and reorders §17.7 to place -apple before -gtk.
  • Updates docs/16 item 6 to point to the now-approved design.
File Description
docs/​decisions.md New newest-first decision-log entry recording the owner's accepted §17.8 recommendations and the work order.
docs/​17-camera-preview.md Status changed to approved; §17.2/§17.3 headers marked decided; §17.7 reordered (-apple before -gtk); §17.8 annotated as answered.
docs/​16-device-services.md Tier-3 item 6 note updated from "proposed" to "approved", pointing to the embedding point as next.

Review effort: Balanced

rleibman added a commit that referenced this pull request Nov 2, 2026
Both sides grew the Apple galleries:
- GalleryIos/GalleryMac: Services get device, clipboard and haptics.
- GallerySelfTest: storage -> device -> clipboard -> sheet -> big list, both
  check groups kept.
- build.sbt: the Apple galleries depend on deviceApple, clipboardApple and
  hapticsApple.
- verify-apple.sh's header, docs/12's Apple counts (the two measured apart; the
  combined run is the Mac's) and the decision log keep both.

Measured: platforms/Test/compile clean (type-checks the Apple Scala). Not
measured: the Apple self-tests on the combined gallery, which need the Mac.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rleibman added a commit that referenced this pull request Nov 2, 2026
One conflict, the decision log's top: both 2026-11-01 entries kept. Docs only;
the measurements of b477aed stand.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rleibman added a commit that referenced this pull request Nov 2, 2026
Both sides grew the Apple galleries: Services get device, motion, clipboard and
haptics; the self-test runs storage -> device -> motion -> clipboard -> sheet ->
big list; the Apple galleries depend on motionIos, clipboardApple and
hapticsApple. Docs keep both sides (README, docs/12, 14, 16); the decision log's
2026-11-01 entry moved back to the top.

Measured: platforms/Test/compile clean. #127 is Apple-only, so cc3ee5a's GTK
(137) and Android (86) counts stand. Not measured: the Apple self-tests on the
combined gallery (the Mac's).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rleibman added a commit that referenced this pull request Nov 2, 2026
Both sides grew the Apple galleries: Services get device, location, clipboard
and haptics; the self-test runs storage -> device -> location -> clipboard ->
sheet -> big list; the Apple galleries depend on locationApple, clipboardApple
and hapticsApple. docs/12, 14 and the decision log keep both sides; its
2026-11-01 entry moved back to the top.

Measured: platforms/Test/compile clean. Shared gallery code is unchanged from
427494e but for #127's Apple-only additions. Not measured: the Apple self-tests
on the combined gallery (the Mac's).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0