fix: Forward Deno ServeHandlerInfo to getLoadContext #10042
+44
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bdfcd49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
trunk-io bot
pushed a commit
to arcjet/arcjet-js
that referenced
this pull request
Oct 15, 2024
This adds a Remix adapter. We provide a special `getLoadContext` export which is demonstrated in the example application. It currently looks up the IP from an Express or Deno server, but we're waiting on remix-run/remix#10042 before their Deno plugin will provide the argument we need. Closes #1313
|
We've released Remix support in Arcjet, but without these changes, it won't work on the Deno runtime 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forwards the 2nd argument from the
Deno.serveAPI togetLoadContext. This is the only way to access the IP of a request so it needs to be available if you want to make the IP available in the Context.Testing Strategy:
Setup a Deno example and inspect the info via the
getLoadContexthandler. I didn't see any Deno tests in a quick search, but let me know if I missed them.