8000 Irrigation EC M2a: bounded estimates for species-only coverage gaps by rafatahmed · Pull Request #29 · rafatahmed/Flahax · GitHub
[go: up one dir, main page]
Skip to content

Irrigation EC M2a: bounded estimates for species-only coverage gaps - #29

Merged
rafatahmed merged 6 commits into
mainfrom
feat/ec-m2
Oct 19, 2026
Merged

Irrigation EC M2a: bounded estimates for species-only coverage gaps#29
rafatahmed merged 6 commits into
mainfrom
feat/ec-m2

Conversation

@rafatahmed
@rafatahmed rafatahmed commented Oct 19, 2026 •
edited
Loading
Copy link
Copy Markdown
Owner

Summary

Irrigation EC M2a: species-only coverage gaps now give a bounded estimated result instead of partial. Stacked on #28.

  • O1 and O2 decisions with the audit on the 26 shipped formulas are recorded in the design (§11, §13).
    • O1: CRC λ° for phosphate, with Eq. 8 A and B fitted to measured data and phreeqc.dat as a cross-check.
    • O2: a one-sided bound of 80 S·cm²/mol per charge at infinite dilution.
  • The O2 bound. For uncovered charged species, bound = Σ|z|·80·m. The result carries bounded, ec25_range_ms_cm (known subtotal, subtotal + bound), the midpoint ec25_ms_cm, uncertainty_ms_cm and uncovered_bound_ms_cm. Every uncovered species is still listed.
  • Unchanged rules. O5, unrecorded counterions, temperature, carbon and the ionic-strength domain keep their existing statuses. MODEL_VERSION is now irrigation-ec-mccleskey2012-m2a-experimental.
  • compare_measured_ec reports ec25_range_ms_cm and within_range (inclusive; None when unbounded) as a fact, with no verdict.
  • Shipped formulas. All 26 now return estimated. The widest range is 14.4 % of the midpoint (Generic Wet Season, from citrate pairs). Phosphate stays under the bound.

Not included: M2b phosphate coefficients. They wait for the owner to supply the Muccitelli & DiAngelo (1994) 25 °C KH₂PO₄ and K₂HPO₄ data and a check of the CRC λ°. No parameter is invented.

Test plan

  • Full suite: 281 tests OK locally (before the final docs-only commit)
  • Release hygiene and examples tests pass after the docs commit
  • The docs/conductivity.md example output reproduces exactly
  • CI green

Base automatically changed from docs/m1-signoff to main October 19, 2026 08:29
@rafatahmed
rafatahmed merged commit b6967c3 into main Oct 19, 2026
4 checks passed
@rafatahmed
rafatahmed deleted the feat/ec-m2 branch October 19, 2026 08:47
@rafatahmed rafatahmed self-assigned this Oct 19, 2026
rafatahmed added a commit that referenced this pull request Nov 7, 2026
@rafatahmed
Merge pull request #29 from rafatahmed/feat/ec-m2
10e8ee8 
Irrigation EC M2a: bounded estimates for species-only coverage gaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rafatahmed rafatahmed

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rafatahmed
0