Repository navigation
Close catalogue follow-ups: formulation provenance, counterion sodium, band-end chemistry - #27
Merged
Merged
Conversation
…eat/catalogue-followups
1 of 2 tasks
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
Close catalogue follow-ups: formulation provenance, counterion sodium, band-end chemistry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the three follow-ups of the traceable catalogue (design §12). Stacked on #26.
recommend()salt entry (and the workflow recommendation) carriesprovenance:recordId,identityId,analysisBasis,documentsandflags. The result also carriesidentitiesSha256. Records without provenance sayunattributed; nothing is guessed.solve_weightsandforwardare unchanged.recommendadds formula-counterion sodium that is not already assayed as Na to theNarow andincidentalContributions. This covers chelates (D2) and CH - micro's borax/molybdate. A warning names the source. Grams, eligibility and the fit are unchanged.calculate_irrigation_ec_band(...)returnsnominal,minimumandmaximumirrigation results (pH, supersaturation warnings, EC).not_supported/band_end_open.assay_charge_residual_too_largeat an end.Docs:
docs/materials.mdandCHANGELOG.md. Plan:docs/superpowers/plans/2026-10-19-catalogue-followups.md.Test plan
--checkand release hygiene tests pass