Repository navigation
Add experimental irrigation EC from speciation (McCleskey 2012, M1) - #25
Merged
Merged
Conversation
…ual for irrigation EC
4 tasks done
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
Add experimental irrigation EC from speciation (McCleskey 2012, M1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Experimental M1 of calculated irrigation EC: McCleskey et al. (2012) Eq. 8 applied to FlahaX's own speciation, at 25 °C and I ≤ 0.1 mol/kgw. Python API only; no CLI flag and no grower-facing number.
src/flahax/irrigation_ec.pywithcalculate_irrigation_ec,calculate_irrigation_ec_from_plan,calculate_ec_from_totals,compare_measured_ec,assay_charge_residual,DeclaredPureWater,IrrigationECResult.src/flahax/data/conductivity_mccleskey2012.json, pinned by SHA-256. It is checked against a separately typed fixture.estimated,partial(missing species named, no EC number) ornot_supported. Every result carries a full audit record and the qualifier "Accuracy on this fertilizer mixture has not yet been established."partial, because H2PO4-, MgOH+, CaOH+ and charged chelates have no McCleskey coefficient. M2 needs owner decisions O1–O3.docs/superpowers/specs/2026-10-18-irrigation-ec-mccleskey-design.md) and the M1 plan.This branch was cut from
ci/pin-actions-by-sha, so it also carries that branch's two unmerged commits (Actions pinned by SHA, 0.4.0 publication record).Before merge
docs/audit/2026-10-17-flahax-vs-horticalc/review.md, "Owner sign-off").Test plan
PYTHONPATH="src;." python -m unittest discover -s tests -t .)tools/generate_api_reference.py --checkand release hygiene tests pass