Repository navigation
feat: complete grower batch and mix acceptance - #232
Merged
Merged
Conversation
This was referenced Nov 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 114 115 +1
Lines 13142 13510 +368
Branches 2571 2664 +93
==========================================
+ Hits 13142 13510 +368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rafatahmed
marked this pull request as ready for review
November 7, 2026 10:56
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
feat: complete grower batch and mix acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the corrected grower workflow in #231 and fixes the solid-reagent display in #229.
Adds real CLI acceptance for all 13 formulas, current-catalogue EDTA-only lettuce, and the original cucumber inputs replayed in saved and full-report views.
Evidence
After: Water-reference and hard-zero regressions pass; convergence is distinct from nutrient matching; actual generated reports and sheets are checked.
Merge Danger
Door: Two-way
The changes can be reverted. Saved historical calculation records remain separate from explicitly migrated input replays.
Blast Radius: Formulation
Candidate selection, numerical search, batch/mix output and saved-session alternatives. Local convergence does not establish a global optimum or physical recipe validation.
Closes #229
Refs #231