Repository navigation
fix: use measured stock solubility and the A/B tank layout (G15-G22) - #230
Merged
Merged
Conversation
Stock solubility compares each product with its own catalogue value, then the
historical table, in the value's own basis, with the source and tank
temperatures shown and nothing interpolated. Statuses are ok, exceeds (blocks)
and not_checked ("no solubility data"); screening_only, inconclusive and the
assumed floors are removed.
Tanks follow the A/B layout: calcium and every micronutrient product in tank A,
phosphates, magnesium sulfate and macro sulfates in tank B. The
magnesium-phosphate rule is removed and calcium-sulfate applies to macro
products only. A batch that needs a tank beyond the available ones names the
pair and the rule. Tests that encoded the old three-tank block are rewritten.
Closes #226
Closes #227
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 13130 13142 +12
Branches 2573 2571 -2
=========================================
+ Hits 13130 13142 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rafatahmed
marked this pull request as ready for review
November 6, 2026 18:18
6 of 18 tasks
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
fix: use measured stock solubility and the A/B tank layout (G15-G22)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
blocked(exit 3); EDTA chelates and KNO3 had no usable solubility result.After: same batch fits tanks A/B, ends
requires_review(exit 0); Mn EDTA 400 g/L, Iron EDTA 45 g/L, KNO3 316 g/L are compared with their basis and temperatures shown.tests/test_tank_layout.pyand rewritten solubility tests; a caller rule produces a real "third tank" blocked batch. Full per-module suite passes; scoped coverage of every changed line and branch: no gaps.ratio=500).Merge Danger
Door: one-way for API/file consumers.
Removed: row statuses
screening_onlyandinconclusive,assumed_density_floor, thescreening_g_per_lfield, grade/review/interpolation qualification of limits, the Mg-P separation.SolubilityRowgainsbasis,source_temperature_c,tank_temperature_c. Common tomato/chilli batches change fromblockedtorequires_review.Blast Radius: batch/mix status and exit codes, tank assignments, solubility rows in summary/report/sheet.
Deviations to review:
group_tankskeepsmax_tanks=None; the two-tank default issummarize_batch(available_tanks=2).limit_atandproduct_gradesare kept; grades select nothing.tests/test_tank_grouping.py, which never existed; tests are intests/test_tank_layout.py._extra_tank_notebelongs on the grouping object. Related bug found: fix: batch console prints "Not available mL" for a solid pH reagent #229.Closes #226
Closes #227