Repository navigation
fix: reconcile sequential dosing and zero-ammonium search - #239
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 115 115
Lines 13709 13717 +8
Branches 2714 2715 +1
=========================================
+ Hits 13709 13717 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
20 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sequential pH results now assess the returned reagent dose, and joint fitting can settle correctly when an explicit zero nutrient maximum excludes a product.
Closes #237. Closes #238.
Fertilizer doses in sequential reassessment, numerical tolerances and iteration limits are unchanged. Includes public API and batch regressions, an explicit dry-reagent fallback fixture, and unreleased documentation. No version change or release.
Evidence
After: Reported nitrate-N is 150.7925611205989 mg/L, matching independent reconstruction; tight-maximum and batch regressions pass.
After: Local stationarity in 15 iterations and 229 evaluations, final pH 6.000000001862645 and exactly zero ammonium. The small public API reproduction drops from 327 to 7 evaluations.
Merge Danger
Door: Two-way. The code changes can be reverted without a data migration.
Blast Radius: Formulation.
Search paths can change across formulas; this is not a universal speedup or global-optimum claim. The zero-ammonium recipe still requires review: excluding the offered calcium nitrate leaves calcium at 0 against a 200 mg/L target. Meeting that target needs a confirmed ammonium-free calcium source, not a weaker maximum.