Repository navigation
fix: keep optional audit dependencies out of test discovery - #205
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 111 112 +1
Lines 12978 13088 +110
Branches 2595 2604 +9
==========================================
+ Hits 12978 13088 +110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rafatahmed
marked this pull request as ready for review
October 29, 2026 20:18
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
…ncies fix: keep optional audit dependencies out of test discovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #204
Makes NumPy and SciPy optional for the catalogue workflow audit. They are imported only inside
fit(), and the tests that need them are skipped (find_spec) when absent, so plainunittest discoverno longer fails with ImportError ontests.test_catalogue_workflow_audit. The audit tool and its test resolve paths and the git revision from the repository root, so they run from any directory. Both files get the SPDX/disclaimer header and ruff formatting, plus tests for the audit failure paths and the CLI.This is PR 1 of the gate-decision plan (2026-10-29): restore a green
mainbefore the owner catalogue and the gate removals.Direct pushes on record:
d6a42dd,12afceeandf9a1054reachedmainby direct push, bypassing the PR requirement and the required checks. History is not rewritten.Recommendation to the owner (settings action, not done here): in branch protection for
main, enable "Do not allow bypassing the above settings" (enforce_admins).Note: the two SciPy-gated tests first run on the 3.13 coverage leg (CI installs
benchmarks/requirements.txt); they could not run locally.