Repository navigation
Every output of one batch agrees: pH path, weights, acid, warnings (#107-#110) - #111
Merged
Merged
Conversation
This was referenced Oct 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107, #108, #109, #110. Found by generating the owner's session (RO, Tomato Stage.1, 100 L tanks, 10 L acid container, nitric 65 %, pH 6) at depths 1, 2 and 3 with identical answers.
#107 root cause:
unadjusted_phis the first recipe without acid; the weighed recipe is the pH plan's refit, which uses less nitrate salt because the acid supplies 16.09 mg/L NO3-N. Newsummary['ph']['mixed_ph'](the weighed recipe without its reagent) feeds every 'after fertilizers' pH.Unchanged: tanks, formulation, chemistry and the selected reagent are identical to before for this session; 524 tests pass (live PHREEQC required).
New systematic test:
tests/test_output_consistency.pyruns the session once and checks every weight, the acid, the pH path, single warnings and report formatting across the terminal, the sheet at each depth, the report and the summary.Strict Sphinx build clean;
tools/verify_distribution.pyPASS; LF.