8000 Field-test fixes for flahax mix; main becomes 0.6.0.dev0 (#98, #99) by rafatahmed · Pull Request #101 · rafatahmed/Flahax · GitHub
[go: up one dir, main page]
Skip to content

Field-test fixes for flahax mix; main becomes 0.6.0.dev0 (#98, #99) - #101

Merged
rafatahmed merged 4 commits into
mainfrom
fix/mix-field-test
Oct 23, 2026
Merged

Field-test fixes for flahax mix; main becomes 0.6.0.dev0 (#98, #99)#101
rafatahmed merged 4 commits into
mainfrom
fix/mix-field-test

Conversation

@rafatahmed
@rafatahmed rafatahmed commented Oct 23, 2026 •
edited
Loading
Copy link
Copy Markdown
Owner

Found by running flahax mix the way a farmer would: the owner's first session, then a sweep of 17 scripted farmer sessions covering every path (fill and one-irrigation modes, RO and well water, mg/L and meq/L reports, missing alkalinity, ticked stores, a label grade, a data-sheet compound, changed and new formulas, no acid, typos, high ratio in the cold).

Fixed

  • flahax mix: the formula step never lists the formulas, and Enter loops forever #98 The formula step listed nothing, and Enter looped on 'This one is needed.' Enter now lists every formula (and every chemical in step 4) to choose by number; a miss says how to see the list; the step says fertilizers come in step 4. Regression test replays the owner's answers (MKP, 20-20-20, Enter, number).
  • 'Do not mix' without a reason. The ph_adjustment and formulation blocks carried no message, so the sheet led with sodium notes. They now say why: no acid offered ('needs an acid to reach pH 5.80; none was offered: add an acid'), each candidate's reason, a declared maximum broken, or the targets missed by more than 1 %. The blocking reason comes first.
  • The terminal no longer points to a report.html that is not written at depths 1-2.
  • Small batches show their volume (0.01 L, not '0 L').
  • A water analysis outside the 5 % screen can be corrected one value at a time ('Correct a value') instead of retyped from the name.
  • 'No salt in this library supplies B' -> 'None of the available products supplies B'.
  • main carries the released version 0.5.0, so pip install --upgrade from GitHub keeps the old package #99 main is 0.6.0.dev0, so pip install --upgrade "git+...@main" replaces an installed 0.5.0 (verified: plain --upgrade in a venv holding 0.5.0 gives 0.6.0.dev0). Publishing procedure gains the step; CITATION.cff keeps the released 0.5.0 and the hygiene test accepts that only for a dev version.

#100, owner decision

A water report that balances on paper but has no chloride measured is still closed on chloride (no automatic switch); flahax mix now notes at entry that chloride is not measured, and the balancing errors end with 'Ask your lab for chloride and sodium'. Closes #100.

Validation

507 tests with live PHREEQC required; strict Sphinx build; tools/verify_distribution.py PASS; LF. Owner's session replayed through python -m flahax mix on the pushed branch.

8000

@rafatahmed
Field test fixes for flahax mix: list formulas on Enter, say why a pl…
377ea65 
…an is blocked, correct one water value; main is 0.6.0.dev0 (#98, #99)
@read-the-docs-community
read-the-docs-community Bot commented Oct 23, 2026 •
edited
Loading
Copy link
Copy Markdown

Documentation build overview

📚 Flahax | 🛠️ Build #35340726 | 📁 Comparing d0e0b94 against latest (e1b77d0)

  🔍 Preview build  

6 files changed · ± 6 modified

± Modified

@rafatahmed rafatahmed mentioned this pull request Oct 23, 2026
Closed
@rafatahmed
rafatahmed merged commit a9bbf97 into main Oct 23, 2026
6 checks passed
@rafatahmed
rafatahmed deleted the fix/mix-field-test branch October 23, 2026 00:27
This was referenced Oct 23, 2026
Merged
Merged
@rafatahmed rafatahmed self-assigned this Oct 23, 2026
This was referenced Oct 23, 2026
Closed
Closed
Closed
rafatahmed added a commit that referenced this pull request Nov 7, 2026
@rafatahmed
Merge pull request #101 from rafatahmed/fix/mix-field-test
688ffd3 
Field-test fixes for flahax mix; main becomes 0.6.0.dev0 (#98, #99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rafatahmed rafatahmed

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A balanced water report without measured chloride (or sodium) blocks the batch

1 participant

@rafatahmed
0