8000 Update the rust-minidump dependencies by gabrielesvelto · Pull Request #66 · rust-minidump/minidump-writer · GitHub
[go: up one dir, main page]

Skip to content

Update the rust-minidump dependencies - #66

Merged
gabrielesvelto merged 1 commit into
rust-minidump:mainfrom
gabrielesvelto:update-rust-minidump-dependency
Dec 6, 2022
Merged

gabrielesvelto merged 1 commit into
rust-minidump:mainfrom
gabrielesvelto:update-rust-minidump-dependency

Conversation

@gabrielesvelto
Copy link
Copy Markdown
Contributor

This makes the minidump-writer crate not depend anymore on the tracing crate (it becomes only a dev dependency) which reduces the footprint of the crate when it's being vendored.

@gabrielesvelto
gabrielesvelto merged commit bb37126 into rust-minidump:main Dec 6, 2022
@Jake-Shadle
Copy link
Copy Markdown
Collaborator

@gabrielesvelto I don't have admin on this repo, it would be nice if you could setup mergify or something so that we don't have to manually merge PRs once they've been reviewed, I always forget on this repo since every other repo I maintain has that setup so I don't have to think about it.

@gabrielesvelto
Copy link
Copy Markdown
Contributor Author

I'm not familiar with it but I'll try looking how you did it in your repos, I'm always happy to reduce the number of manual chores.

@Jake-Shadle
Copy link
Copy Markdown
Collaborator

Here's the typical one we use https://github.com/EmbarkStudios/cargo-deny/blob/main/.mergify.yml

8000

@sylvestre
Copy link
Copy Markdown

@JohanLorenzo is an expert in this

@JohanLorenzo
Copy link
Copy Markdown

Hey @gabrielesvelto!

Mergify was approved to be used at Mozilla including on one of our flagship products (more info in bug 1780006. Our most complete config lives at https://github.com/mozilla-mobile/firefox-android/blob/54c1653a88edb76472c9579ed7834ae61b6e98e0/.mergify.yml. Feel free to ping me if you need any additional help 🙂

@gabrielesvelto
Copy link
Copy Markdown
Contributor Author

@JohanLorenzo I will, this can be useful here, in the rust-minidump repo as well as in the dump_syms one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0