Repository navigation
Replace memmap with memmap2 - #5
Merged
Merged
Conversation
Collaborator
|
Thank you! |
G36maid
added a commit
to G36maid/minidump-writer
that referenced
this pull request
May 16, 2026
…k logging, procfs test - Use getcontext() instead of zeroed ucontext in tests (Finding rust-minidump#3) so register extraction is actually tested with non-zero values. - Assert exception thread_id exists in thread list (Finding rust-minidump#2) to catch orphaned exception references. - Store mapping names as OsString instead of String (Finding rust-minidump#5) to preserve non-UTF-8 paths until lossy conversion at write time, matching Linux implementation. - Log stack copy failures instead of silently ignoring (Finding rust-minidump#4) with log::warn for both crash and non-crash thread paths. - Make handle_data_stream test procfs-aware (Finding #1) so it doesn't silently pass when /proc/<pid>/fd is absent.
G36maid
added a commit
to G36maid/minidump-writer
that referenced
this pull request
May 16, 2026
…k logging, procfs test - Use getcontext() instead of zeroed ucontext in tests (Finding rust-minidump#3) so register extraction is actually tested with non-zero values. - Assert exception thread_id exists in thread list (Finding rust-minidump#2) to catch orphaned exception references. - Store mapping names as OsString instead of String (Finding rust-minidump#5) to preserve non-UTF-8 paths until lossy conversion at write time, matching Linux implementation. - Log stack copy failures instead of silently ignoring (Finding rust-minidump#4) with log::warn for both crash and non-crash thread paths. - Make handle_data_stream test procfs-aware (Finding #1) so it doesn't silently pass when /proc/<pid>/fd is absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crate memmap has been marked unmaintained, see the advisory.
This PR replaces the dependency with memmap2, which is a maintained fork of memmap.