8000 length-argument of copy_from_process() should be usize not isize · Issue #3 · rust-minidump/minidump-writer · GitHub
[go: up one dir, main page]

Skip to content

length-argument of copy_from_process() should be usize not isize #3

Closed

Description

@msirringhaus

Its usize at the moment, but should be isize.
Then remove the corresponding try_into() in the section-writer part and rewire the test_write_early_abort() test to pass in a NULL-pointer or something instead of usize::MAX to trigger an early abort.

Actually, this makes no sense. copy_from_process() should accept a usize as length-argument, instead. This might lead to a overflow when pointer + length > usize::MAX, but is better than allowing the user to hand in negative lengths as part of the API.

Activity

  1. changed the title [-]Make AppMemory.length an isize[/-] [+]length-agrument of copy_from_process() should be usize not isize[/+] on Jan 29, 2021
  2. changed the title [-]length-agrument of copy_from_process() should be usize not isize[/-] [+]length-argument of copy_from_process() should be usize not isize[/+] on Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0