Do not trim a block from expression if its condition will go multi-line #3042

topecongiro · 2018-09-20T16:08:25Z

Closes #3040.

N.B. this PR does not handle adding a block to an arm body. E.g. the following snippet will not get formatted.

            DevtoolScriptControlMsg::WantsLiveNotifications(id, to_send) => match documents
                .find_window(id)
            {
                Some(window) => {
                    devtools::handle_wants_live_notifications(window.upcast(), to_send)
                }
                None => return warn!("Message sent to closed pipeline {}.", id),
            },

IMHO adding/removing a block around match arm's body has been buggish and has confused users, so I think we should review and refactor its logic.

nrc · 2018-09-21T02:25:25Z

Thank you!

topecongiro added 2 commits September 21, 2018 00:57

Add a test for rust-lang#3040

ec32c96

Do not trim a block from expression if its condition will go multi-line

f70d139

nrc merged commit 4568c1a into rust-lang:master Sep 21, 2018

topecongiro deleted the issue-3040 branch July 21, 2019 05:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not trim a block from expression if its condition will go multi-line #3042

Do not trim a block from expression if its condition will go multi-line #3042

Do not trim a block from expression if its condition will go multi-line #3042

Do not trim a block from expression if its condition will go multi-line #3042

Conversation