[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote peer added with same adress to debug #5411

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

timvisee
Copy link
Member

Only show the following warning if the peer address actually changed.

# 2024-11-11T09:39:11.379867Z  WARN storage::content_manager::consensus::persistent: Replaced address of peer 5828499418624065 from http://qdrant-0.qdrant-headless:6335/ to http://qdrant-0.qdrant-headless:6335/

Until now it's not entirely clear in what situation this message would show up.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee changed the title Only warn about replacing a peer address if it is different than before Demote peer added with same adress to debug Nov 11, 2024
@timvisee timvisee marked this pull request as ready for review November 11, 2024 13:08
@timvisee timvisee merged commit 03c6c67 into dev Nov 11, 2024
18 checks passed
@timvisee timvisee deleted the warn-replaced-address-if-different branch November 11, 2024 13:43
timvisee added a commit that referenced this pull request Nov 12, 2024
* Only warn about replacing a peer address if it is different than before

* Keep peer added message, demote added with same address to debug
@timvisee timvisee mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants