[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger optimizers when uploading snapshots #5140

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Trigger optimizers when uploading snapshots #5140

merged 5 commits into from
Sep 24, 2024

Conversation

JojiiOfficial
Copy link
Contributor

Fixes #5139

timvisee
timvisee requested changes Sep 24, 2024
View reviewed changes
lib/collection/src/shards/replica_set/mod.rs Outdated Show resolved Hide resolved
lib/collection/src/shards/local_shard/mod.rs Outdated Show resolved Hide resolved
lib/collection/src/shards/proxy_shard.rs Outdated Show resolved Hide resolved
lib/storage/src/content_manager/snapshots/recover.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Open
@JojiiOfficial JojiiOfficial merged commit 792bbb7 into dev Sep 24, 2024
17 checks passed
@JojiiOfficial JojiiOfficial deleted the snapshot_trigger_optimizer branch September 24, 2024 15:52
@timvisee timvisee mentioned this pull request Sep 24, 2024
Closed
generall pushed a commit that referenced this pull request Oct 8, 2024
@JojiiOfficial @timvisee @generall
Trigger optimizers when uploading snapshots (#5140)
428e09d 
* Trigger optimizers when uploading snapshots

* Trigger optimizers through new method when optimizer config is updated

* review remarks

* Add comment on why ignoring channel send errors is fine

* Remove obsolete return value omitting

---------

Co-authored-by: timvisee <tim@visee.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvisee timvisee timvisee approved these changes

@ffuugoo ffuugoo Awaiting requested review from ffuugoo

@tellet-q tellet-q Awaiting requested review from tellet-q

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JojiiOfficial @timvisee