[Strict mode] default config #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
reviewed
Sep 23, 2024
Comment on lines
+669
to
+672
| // Global | ||
| /// Whether strict mode is enabled for a collection or not. | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub enabled: Option<bool>, |
There was a problem hiding this comment.
Can we make this non-optional? I guess it's good to be explicit here.
Comment on lines
+1758
to
+1774
| impl From<StrictModeConfigDiff> for segment::types::StrictModeConfig { | ||
| fn from(value: StrictModeConfigDiff) -> Self { | ||
| Self { | ||
| enabled: value.enabled, | ||
| max_query_limit: value.max_query_limit.map(|i| i as usize), | ||
| max_timeout: value.max_timeout.map(|i| i as usize), | ||
| unindexed_filtering_retrieve: value.unindexed_filtering_retrieve, | ||
| unindexed_filtering_update: value.unindexed_filtering_update, | ||
| search_max_hnsw_ef: value.search_max_hnsw_ef.map(|i| i as usize), | ||
| search_allow_exact: value.search_allow_exact, | ||
| search_max_oversampling: value.search_max_oversampling.map(f64::from), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
If we can construct a regular config from a diff, I don't see much reason to also have a diff type.
Comment on lines
+667
to
+668
| #[derive(Debug, Deserialize, Serialize, JsonSchema, Validate, Clone, PartialEq, Default)] | ||
| pub struct StrictModeConfig { |
There was a problem hiding this comment.
At this time the -Diff struct of this appears to be exactly the same. In that case, does it make sense to use a diff structure at all?
timvisee
approved these changes
Sep 23, 2024
4ae2a7b
to
2551585
Compare
d50301f
to
70e7d1f
Compare
2551585
to
9a392f8
Compare
70e7d1f
to
4a966cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5003
Since we need the strict mode config struct to be in
/lib/segmentbut also need a struct that derivesMerge, I decided to create two structs for strict mode: StrictModeDiff and StrictMode.