[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete redundance package for apiserver storage code. #7778

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Delete redundance package for apiserver storage code. #7778

merged 1 commit into from
Oct 16, 2023

Conversation

yanggangtony
Copy link
Contributor
@yanggangtony yanggangtony commented Jun 10, 2023 •
edited
Loading

Description

Delete redundance package for apiserver storage code.

None

@yanggangtony yanggangtony requested a review from a team as a code owner June 10, 2023 21:48
@marvin-tigera marvin-tigera added this to the Calico v3.27.0 milestone Jun 10, 2023
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Jun 10, 2023
@caseydavenport
Copy link
Member

/sem-approve

@caseydavenport caseydavenport added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact merge-when-ready labels Jun 23, 2023
@marvin-tigera marvin-tigera removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Jun 23, 2023
@marvin-tigera
Copy link
Contributor

Removing "merge-when-ready" label due to new commits

Delete redundance package for apiserver storage code.
110e5ee 
Signed-off-by: yanggang <gang.yang@daocloud.io>
@yanggangtony
Copy link
Contributor Author

@caseydavenport
this pr is so long time , would it be closed or merged then?

@caseydavenport
Copy link
Member

@yanggangtony sorry for losing this one. It seems fine to merge, so long as it passes tests.

@caseydavenport
Copy link
Member

/sem-approve

@caseydavenport caseydavenport merged commit 89f93e2 into projectcalico:master Oct 16, 2023
2 checks passed
@yanggangtony
Copy link
Contributor Author

Thanks.

@yanggangtony yanggangtony deleted the apiserver branch October 16, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Milestone
Calico v3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yanggangtony @caseydavenport @marvin-tigera