Repository navigation
feat(bench): SIMD benchmarking and crossover analysis (#229) - #253
Merged
Merged
Conversation
…le optimization) Covers issues #207 and #206: extends optimizer::plan() to accept Expr clauses and interleave them at the earliest position where their variables are bound, and routes the StratifiedEvaluator mixed-rules path through the updated planner. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d rules) TDD plan covering optimizer.rs, matcher.rs, executor.rs, evaluator.rs, and a new Criterion benchmark. 9 tasks, each with exact file paths, code blocks, and expected test output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…#205) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add a concise 'WASM omission' comment at every existing and planned #[cfg(not(feature = "wasm"))] ordering gate explaining why sorting is disabled on WASM targets (small datasets, deterministic behaviour). The full rationale lives in the selectivity_score() doc comment; all other sites reference it with a short cross-reference. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace todo!() stubs with wide 0.7 implementations: valid_time_filter_simd (i64x4 with CmpGt/Not/move_mask), as_of_filter_simd (u64x4), and sum_simd_i64 (i64x4 accumulator). All 10 unit tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…groups (#229) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
adityamukho
added a commit
that referenced
this pull request
May 17, 2026
Wave 2 (PRs #249, #251, #253) was missing from CHANGELOG.md, ROADMAP.md, and TEST_COVERAGE.md: - CHANGELOG.md: add Wave 2 section between Wave 3 and Wave 1 entries - ROADMAP.md: add Wave 2 to timeline between Wave 1 and Wave 3 - TEST_COVERAGE.md: add Wave 2 completion status note (no new tests — all optimizer + benchmark work covered by existing 850 tests) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add
30A2
this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wide 0.7as a non-WASM dev-dependency (zero production binary size impact)benches/simd_helpers.rs:valid_time_filter_simd,as_of_filter_simd,sum_simd_i64with 10 unit testssimd_temporal,simd_as_of,simd_aggregate— each at 5 dataset sizes (100 → 1M), scalar vs SIMD side-by-sidedocs/simd-analysis.md: crossover findings and final recommendationKey findings
valid_time_filter_simd,as_of_filter_simd): SIMD slower than scalar at all sizes — LLVM autovectorization already captures available gains; recommendation is Skipsum_simd_i64): 2–2.8× speedup at all sizes — real gain, but production adoption requires struct-of-arrays storage layout; recommendation is Revisit with SoA layoutCloses #229
Test plan
cargo test)cargo bench -- simd)cargo clippy -- -D warningscleancargo fmt --checkclean🤖 Generated with Claude Code