Repository navigation
perf: avoid per-EAV allocations in net assertion - #236
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Two unit tests directly exercising net_asserted_facts: - multiple retractions of the same EAV (max_retract_tx must be the global maximum across all retractions, not the first seen) - retraction wipes all valid-time windows for the same EAV triple Also expands the function doc comment with an implementation note documenting the two-map single-pass approach and the known memory tradeoff for high-retraction workloads (by_window holds all assertions before the filter_map runs), as called out in the PR review. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ryline-design.md" This reverts commit fb74d98.
This reverts commit 900016a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vec<Fact>grouping innet_asserted_factswith flat maps for max retraction tx and valid-time windows.Verification
cargo test --test bitemporal_test same_eav -- --nocapturecargo test --test bitemporal_test retraction_cancels -- --nocapturecargo bench --bench minigraf_bench -- "^concurrent_btree_scan/100k"100k_2t: 130.39 ms100k_4t: 182.85 ms100k_8t: 403.63 ms, noisy but below the original post-regression local median of 425.27 mscargo testcargo fmt --check,cargo clippy,cargo test