Repository navigation
ci: raise Bencher threshold to 0.999 for concurrent benchmark groups - #118
Merged
Merged
Conversation
Concurrent benchmarks measure mutex/thread scheduling latency, which is highly sensitive to shared CI runner load. At the standard 0.99 upper boundary the t-test fires on normal runner variance (as seen in issue #116 / run 24179274502) even when no code changed. Sequential benchmark groups keep the tighter 0.99 threshold. Applies to both bench_light.yml and bench.yml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 83.73% 83.73%
=======================================
Files 26 26
Lines 4729 4729
=======================================
Hits 3960 3960
Misses 769 769 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concurrent/*,concurrent_file/*,concurrent_btree_scan) fire false-positive regressions on CI because they measure mutex/thread scheduling latency, which varies with shared runner load — not code changes--threshold-upper-boundaryfrom0.99→0.999for all concurrent groups in bothbench_light.ymlandbench.yml0.99thresholdthresholdfield so each group's sensitivity is explicit and independently adjustableTest plan
Closes #116
🤖 Generated with Claude Code