Repository navigation
ci: split heavy bench into one job per benchmark group - #117
Merged
Merged
Conversation
Previous jobs combined 2–5 bench functions per runner and hit the 6-hour GitHub Actions wall-clock limit. Each runner now runs exactly one Criterion filter, matching the approach already used in bench_light.yml. timeout-minutes raised from 90 → 360 (matching bench_light) and fail-fast disabled so a single slow job cannot cancel siblings. Regression reporting moved inline (continue-on-error + conditional issue step) to eliminate the now-unnecessary report-regression fan-in job. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 83.73% 83.73%
=======================================
Files 26 26
Lines 4729 4729
=======================================
Hits 3960 3960
Misses 769 769 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid
2F7D
suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bench.ymlto use a matrix strategy (21 jobs, one per benchmark group) matching the approach already used inbench_light.ymltimeout-minutesraised from 90 → 360 to matchbench_light;fail-fast: falseadded so a single slow job cannot cancel siblingscontinue-on-error+ conditional issue step), eliminating the oldreport-regressionfan-in job^insert/vs^insert_file/) ensure each job runs exactly the intended benchmarks with no cross-contaminationTest plan
workflow_dispatchand verify all 21 matrix jobs start and complete without timeoutfail-fast: false)Fixes: https://github.com/adityamukho/minigraf/actions/runs/24193906944
🤖 Generated with Claude Code