Repository navigation
Phase 7.9: Publish Prep — API narrowing, rustdoc, clippy clean, CI matrix (v0.19.0) - #109
Merged
Merged
Conversation
…self) -> Repl<'_> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…helpers Delete the now-dead `inner_fact_storage` method from `Minigraf` (no callers after Repl refactor) and remove unused `&self` from the three private Repl helper methods (`is_command_complete`, `print_result`, `format_value`), calling them via `Self::` instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…evel rustdoc - Replace src/lib.rs with narrow public surface: only db, repl modules public; graph, query, storage, temporal, wal are pub(crate) - Re-export only: Minigraf, OpenOptions, OpenOptionsWithPath, WriteTransaction, Repl, EntityId, Value, QueryResult, AsOf, ValidAt, BindValue, PreparedQuery - Add crate-level rustdoc with quick-start doctest using Minigraf::in_memory() - Add #![warn(missing_docs)] and #![cfg_attr(docsrs, feature(doc_cfg))] - Update integration tests to use new public API paths (minigraf::Value, minigraf::QueryResult) instead of private module paths - Migrate bitemporal_test, complex_queries_test, concurrency_test, recursive_rules_test from FactStorage/DatalogExecutor to Minigraf::in_memory() - Fix doctests in src/db.rs, src/graph/types.rs, src/graph/storage.rs, src/query/datalog/rules.rs that referenced now-internal module paths - Fix wal_test.rs to avoid FileHeader/PAGE_SIZE (now internal): inline PAGE_SIZE=4096 constant and read raw bytes for header field checks Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fact, TxId, Attribute, TransactOptions, VALID_TIME_FOREVER, tx_id_* and FactStorage are now pub(crate); only Value and EntityI F438 d remain pub as they are part of the public API re-exported from lib.rs. Dead pub use lines in graph/mod.rs are replaced with pub(crate) use. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove unused re-exports from graph/mod.rs (all callers use `crate::graph::types::*` directly; only `FactStorage` needed via `crate::graph::FactStorage`). Move test-only methods/functions (`get_facts_by_entity`, `get_facts_by_attribute`, `get_facts_valid_at`, `get_facts_by_entity_attribute`, `get_current_value`, `fact_count`, `asserted_fact_count`, `index_counts`, `resolve_fact_ref`, `next_string_prefix`) to `#[cfg(test)]` impl/free-function blocks. Move `with_asserted` and `is_retracted` on `Fact` to a `#[cfg(test)]` impl block. Move `tx_id_from_system_time` and `tx_id_to_system_time` into the types test module. Fixes all dead_code and unused_import warnings originating from src/graph/. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rage/query/wal modules Category A: removed unused pub use re-exports from query/mod.rs, query/datalog/mod.rs (keeping QueryResult for repl.rs), and restored FileBackend re-export with #[allow(unused_imports)] (used in tests). Category B: added #[allow(dead_code)] to legitimate-but-unused API methods in storage traits, btree_v6, cache, persistent_facts, index, packed_pages, executor, evaluator, functions, rules, types, and temporal; added #![allow(dead_code)] module attribute to legacy btree.rs. Also fixed unused variable and unused import in test code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace .read().unwrap()/.write().unwrap() in cache.rs and evaluator.rs
with .expect("lock poisoned"), and wal.as_mut().unwrap() in db.rs with
.expect("WAL not initialized") for clearer panic messages in published lib.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… BindValue, PreparedQuery
- CLAUDE.md: bump test count 780 → 788 - README.md: update phase badge 7.8 → 7.9 - ROADMAP.md: mark Phase 7 and 7.9 complete; update Current Focus and version history - CHANGELOG.md: add v0.19.0 entry (API visibility, rustdoc, clippy, CI matrix) - TEST_COVERAGE.md: bump counts (780 → 788), add Phase 7.9 completion section, update next steps Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 83.61% 83.73% +0.12%
==========================================
Files 26 26
Lines 4816 4729 -87
==========================================
- Hits 4027 3960 -67
+ Misses 789 769 -20
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pub(crate); public surface is nowMinigraf,OpenOptions,WriteTransaction,Repl,Value,EntityId,QueryResult,AsOf,ValidAt,BindValue,PreparedQueryMinigraf::repl(): New factory method replaces directRepl::new(FactStorage)—Repl<'_>now borrows&Minigraffor lifetime safety; users calldb.repl().run()/// doccoverage on all public items with# Examplesdoctests;#![warn(missing_docs)]enforced;[package.metadata.docs.rs]added for docs.rs buildscargo clippy -- -D warningspasses;FileHeader::to_bytestakesselfby value; strict clippy step added to CI.unwrap()in library code replaced with descriptive.expect()messagesrust.yml; strict clippy step added torust-clippy.ymlTest Plan
cargo test— 788 tests passing (0 failing)cargo doc --no-deps— zero warningscargo clippy -- -D warnings— zero warningscargo publish --dry-run— passescargo fmt --check— clean (pre-push hook verified)🤖 Generated with Claude Code