Repository navigation
ci(browser): run the BrowserDb tests in Firefox, Chrome and Safari on main - #906
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
… main Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
adityamukho
force-pushed
the
ci/main-wasm-browser-lanes
branch
from
November 18, 2026 03:59
bd0ec02 to
75be0ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainhas no browser CI lane, so the v2BrowserDb/IndexedDB tests (including the #894 flush tests) ran nowhere in CI. This adds.github/workflows/wasm.yml, modelled on the one onv3:wasm-pack test --headless --features browser).macos-15throughsafaridriver.main'sBrowserDbhas no worker mode (nominigraf_browser_workercfg), so there is nothing to run.wasm-pack testcould not build onmain: native-only integration tests (error_codes_{foundation,storage,wal}_test.rs) andexamples/pid_ns_helper.rsfailed to compile for wasm32. They now carry the same wasm32 guardsv3uses. No runtime behaviour changes.docs/TEST_COVERAGE.mddocuments the standardwasm-packcommand; thelint.ymlcomment is corrected.Verification
wasm-pack test --headless --firefox --features browserpasses (26 tests); nativecargo test1,326 passed, 9 ignored;cargo fmt --checkclean.Follow-up to #904 (Evaluator gap on
main). Separate from the wasm clippy PR; the two edit the samelint.ymlcomment, so the second to merge needs a trivial rebase.🤖 Generated with Claude Code