Repository navigation
test: add regression test for issue #82 (or/or-join deduplication) - #88
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 84.59% 84.55% -0.04%
==========================================
Files 25 25
Lines 4549 4551 +2
==========================================
Hits 3848 3848
- Misses 701 703 +2 🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add regression tests for issue #82: or/or-join deduplication bug that was fixed in commit 4c8270d.
The bug: HashMap::iter() returns entries in non-deterministic order, causing identical bindings to produce different Vec orderings and fail to deduplicate.
The fix: sort key before inserting into BTreeSet (already present in apply_or_clauses).
Tests added
test_or_does_not_return_duplicate_bindings- verifies or deduplicates correctlytest_or_join_does_not_return_duplicate_bindings- verifies or-join deduplicates correctlyBoth tests verify that an entity matching both branches appears exactly once, not twice.