8000 docs(bench): map semantic permutations to correctness tests (Refs #842) by adityamukho · Pull Request #864 · project-minigraf/minigraf · GitHub
[go: up one dir, main page]

Skip to content

docs(bench): map semantic permutations to correctness tests (Refs #842) - #864

Merged
adityamukho merged 1 commit into
v3from
docs/842-semantic-permutations
Nov 6, 2026
Merged

adityamukho merged 1 commit into
v3from
docs/842-semantic-permutations

Conversation

@adityamukho
Copy link
Copy Markdown
Collaborator

Related #842 (X07 of the #776 close-out).

What this adds

  • docs/benchmarks/842-semantic-permutations/README.md: the X07 report pinned to v3 5d85c36f9a4ec3056d59a14982ff5bd3490a2263.
  • targets.csv: 128 curated correctness tests (130 targets in 29 cells) for the numeric, bind, cross-kind join and forced-planner families.
  • map.py (standard library): checks every target against the pinned plain and test-hooks inventories, and writes a lexical index of all 2,079 Rust tests. Its output reproduces byte for byte from the committed lists in evidence/.
  • Shared docs: the X07 row and the C15/C16 preflight wording in bench-coverage-v3.md, plus CLAUDE, README, ROADMAP, CHANGELOG, TEST_COVERAGE and BENCHMARKS.

No production code, public API, test or nightly-route change. Nothing was timed: the inventory is a build plus --list.

Findings

  • Every cell has correctness coverage; no missing answer contract. 17 of the tests exist only in the test-hooks build, which CI runs (rust.yml).
  • Prepared queries substitute their bind values before planning (prepared.rs bind), so a forced-plan × bind matrix would repeat the literal-query matrices.
  • Attribution limits:
    1. No hook forces a join kind.
    2. Entity and value probes both report IndexNestedLoopJoin, so the operator_paths entity/value labels rest on query shape, not a counter.
    3. Only the six join controls check operators before timing. The anti/union, aggregate and keyword controls check answers only.
  • Confounders, stated next to the comparisons:
    • The hash_* controls scan every attribute (20k facts) and then filter.
    • The dynamic_* keyword controls add a binding lookup and a clone per row.
  • Decision: X07 stays excluded and no nightly ID changes. Any new representative needs a distinct cost hypothesis, a strategy preflight and a bounded budget.

Verification

  • map.py reruns on the committed evidence and reproduces tests.csv, summary.json and targets.json byte for byte.
  • All 130 targets resolve to exactly one listed test.
  • All relative links resolve.
  • Codex review skipped (Codex out of credits).

🤖 Generated with Claude Code

https://claude.ai/code/session_01H2a7QoYX6tc5G3sKVzvLjD

Adds the X07 report for core revision 5d85c36 on v3. It maps the numeric,
bind, cross-kind join and forced-planner families excluded from nightly
benchmarks to 128 curated correctness tests (130 targets in 29 cells),
verified against the pinned plain and test-hooks inventories (17 tests are
hooks-only; CI runs both builds). A standard-library script reproduces a
lexical index of all 2,079 Rust tests and the target check byte for byte.

No missing answer contract was found. Three attribution limits are
recorded: no join-kind switch, entity and value probes share an operator
counter name, and only the six join controls check operators before
timing. The hash-scan and keyword binding/clone confounders sit next to
the comparisons. X07 stays excluded; no nightly ID changes.

No production code, public API, test or nightly-route change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01H2a7QoYX6tc5G3sKVzvLjD
@adityamukho
adityamukho merged commit a95e51f into v3 Nov 6, 2026
18 checks passed
@adityamukho
adityamukho deleted the docs/842-semantic-permutations branch November 6, 2026 03:49
@codecov
codecov Bot commented Nov 6, 2026
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0