Repository navigation
test: close v3 memory and scaling acceptance gaps (#837) - #848
Merged
Merged
Conversation
1 task done
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled acceptance jobs could pass without nonlinear/multistratum recursion, custom chunk bounds, or confirmed RSS assertions. Add those fixtures and require the exact ten tests and nine measured RSS records; empty, partial, renamed or skipped targets now fail. Linux measurement failures are explicit, and storage checks exact bytes rather than a truncated ratio.
Refs #837; follows the historical evidence audit in #847. No production behavior, API, dependency, or format changes.
Type of change
Validation
4f7f1caa3ae2aa5f03b5e0a28b8dc3ceeef567bc.docs/benchmarks/837-acceptance-gaps/. A subsequent test-only refactor shares the same storage byte assertion and measurement output between the ordinary and million-fact fixtures, so normal coverage CI exercises them. The retained acceptance measurements remain pinned to the recorded source SHA.Notes for reviewer
Recursive scales are 256/512 nodes with explicit RSS, absolute-time, time-ratio and INT-020 assertions. Custom chunks include million-fact statements and both public clamps. The verifier is loaded from the workflow SHA, tests from the pinned source SHA; artifacts retain Cargo.lock. These are fixed-shape acceptance bounds, not Bencher memory metrics or an accounting-disabled control.
Merge this v3 change before the matching default-branch scheduler PR #849. The successful acceptance run was a dedicated dispatch. The shared-helper fix (
e2b843987) passed coverage run 41784818253 and Codecov patch coverage is now 87.50% (85% target). Unrelated PR checks were not monitored.