Repository navigation
fix(fuzz): count EDN-separated and valid-at joins in evaluator guard - #845
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly evaluator fuzz run timed out because its join guard underestimated three inputs. It treated
,?vas a constant instead of an EDN-separated variable, missed adjacent symbol/keyword tokens, and did not count the per-visible-fact multiplication of:db/valid-at.Tokenize pattern atoms while preserving quoted strings, and estimate valid-at scans as
[entity _ _]. Add the three exact artifacts, reduced regressions, and coverage documentation. This changes only the fuzz harness; database behavior is unchanged.Fixes #835
Type of change
Validation
rustfmt --checkon both changed Rust files andgit diff --checkpass.Checklist
Notes for reviewer
The guard remains a conservative lexical estimate rather than a full Datalog parser. Valid-at metadata constraints are deliberately omitted from its estimate so they cannot hide the underlying fact-scan multiplication.