8000 fix(storage): include asserted in load_fact duplicate detection key (issue #75) by adityamukho · Pull Request #80 · project-minigraf/minigraf · GitHub
[go: up one dir, main page]
Skip to content

fix(storage): include asserted in load_fact duplicate detection key (issue #75) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityamukho merged 1 commit into from
Apr 3, 2026
Merged

fix(storage): include asserted in load_fact duplicate detection key (issue #75) #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions src/graph/storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,18 +253,19 @@ impl FactStorage {
/// counter so subsequent `transact()` calls get correct tx_count values.
///
/// Checks for duplicate facts before loading (based on entity, attribute, value,
/// valid_from, valid_to, and tx_count).
/// valid_from, valid_to, tx_count, and asserted).
pub fn load_fact(&self, fact: Fact) -> Result<bool> {
let mut d = self.data.write().unwrap();

// Check for duplicate based on unique key (entity, attribute, value, valid_from, valid_to, tx_count)
// Check for duplicate based on unique key (entity, attribute, value, valid_from, valid_to, tx_count, asserted)
if d.facts.iter().any(|f| {
f.entity == fact.entity
&& f.attribute == fact.attribute
&& f.value == fact.value
&& f.valid_from == fact.valid_from
&& f.valid_to == fact.valid_to
&& f.tx_count == fact.tx_count
&& f.asserted == fact.asserted
}) {
return Ok(false); // Already exists, not loaded
}
Expand Down Expand Up @@ -1657,4 +1658,26 @@ mod tests {
// Count should remain the same
assert_eq!(storage.fact_count(), 2);
}

#[test]
fn test_load_fact_duplicate_detection_includes_asserted() {
let storage = FactStorage::new();
let entity = uuid::Uuid::new_v4();
let attr = ":test/attr".to_string();
let value = Value::Integer(42);

// Load an asserted fact
let mut fact1 = Fact::new(entity, attr.clone(), value.clone(), 1);
fact1.asserted = true;
assert!(storage.load_fact(fact1).unwrap());

// Load a retraction for the same entity/attr/value/tx_count but different asserted
let mut fact2 = Fact::new(entity, attr.clone(), value.clone(), 1);
fact2.asserted = false;
// Should NOT be deduplicated - different asserted values should both survive
assert!(storage.load_fact(fact2).unwrap());

// Both facts should be present
assert_eq!(storage.fact_count(), 2);
}
}
Loading
0