Repository navigation
Audit release binary size and rank measured reductions (#772) - #798
Merged
Merged
Conversation
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
adityamukho
marked this pull request as ready for review
October 30, 2026 05:21
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pinned v3 CLI has only 24 bytes of headroom under its current size cap, and the shipped
distprofile produces a substantially larger artifact than the release profile checked by CI. This audit records reproducible baselines, symbol/section attribution, seven independent source prototypes, and ranked follow-ups for #772.Start with
docs/audits/772/README.md. The adjacent scripts, dependency lock snapshot, prototype diffs and raw measurements reproduce the findings. This PR changes documentation and audit artifacts only; production code, size caps, coverage floors, public API and file format remain unchanged.Measured opportunities and decisions:
Validation ran on the bench machine. The unchanged baseline's all-features suite passed with tmpfs fixtures (2,072 passes across 80 printed summaries, including child-process runs; zero failures, 20 ignored). The initial disk-backed baseline run was interrupted during journal waits, not counted as passing. The set prototype passed 23 codec tests and all 10 set integration tests on disk; the reader passed its two focused unit tests. Both prototypes passed Rust 1.89 all-features checking and native/browser/WASI builds. Packaged browser glue differs only in generated internal indices/comments. Runtime evidence includes 164 paired equal-count reader comparisons, eight checked CLI pairs, and four socket-swapped sort-probe rounds. Browser execution and broader reader validation remain gates for the implementation follow-ups.
Audit scripts/data parse, prototype patch dry runs, rustfmt and diff-whitespace checks passed. No release or feature documentation changes are needed because this PR ships no runtime behavior.