Repository navigation
fix(query): align ordinary aggregate value handling (#789) - #792
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary
sumandsum-distinctnow ignore nonnumeric arguments; ordinarymin/maxaccept every non-nil value using the existing window order. Sum over10,"unknown",20returns 30. Existing empty-query conventions and all-nil min/max group dropping are preserved.Numeric filtering happens before sum-distinct retention and memory charging. Count/distinct identity, window behavior, and count-only ordered Aggregate eligibility remain unchanged (#781 owns expansion). INT-041/043/044 stay reserved and are documented as deprecated. This targets v3 only and is reconciled with merged #791, preserving avg and its heap accounting.
Refs #789. The approved spec, implementation plan, and verification record are included under
docs/superpowers/.Validation:
test-hookstests and the dedicated sum/avg retained-heap test pass. Red/green regressions and all legacy aggregate expectations are updated.Companion version-scoped site documentation: project-minigraf/minigraf-docs#87.