Repository navigation
docs(spec): prepared queries in every binding (#181) - #737
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design for #181:
prepare→ prepared handle withexecute(bindings)/query(bindings)in all seven bindings (UniFFI ×4 + template, Node, C,BrowserDb).Decisions (from the brainstorm): map of slot → bind value; typed form plus plain host values in every binding; bind mistakes move from INT-033/034/035 to new API codes (provisionally API-022..024; #316 takes API-021);
EntityandVal(Ref)interchangeable so a host UUID can bind anywhere; UniFFI/BrowserDbhandles keep the db alive, Node/Cclose()releases prepared queries (thenAPI-018);MiniGrafErrorgainsApi.Verified on
v3: a corePreparedQueryoutliving itsMinigrafkeeps the file registered and locked (STG-025 / STG-026 on reopen), andPreparedQueryisSend + Sync.Flagged, outside this spec: the #180 and #316 specs both claim
QRY-014.Codex review: 3 findings, fixed (parse once / plan per execution, #306 code mapping) or already covered (
closed("database")).Doc-only; held for review before merge.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Urda7FD9CYYoxdeGGJa11x