Repository navigation
docs(spec): set values and set-membership predicates (#316) - #732
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TcpoiFyFeQQQELL872LfQF
…sizes, serde Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TcpoiFyFeQQQELL872LfQF
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design spec for #316:
Value::Set(#{...}), thein?/not-in?/any-in?/all-in?/none-in?predicates, andcollect-set.Spec:
docs/superpowers/specs/2026-10-24-set-values-design.mdDecisions settled with the maintainer (§1):
0x08after Ref; inline element encoding up to 64 B, spilled to a value page with the long-string scheme above that.Value's total order (-0.0 = 0.0, one NaN, keyword ≠ ref);-0.0kept.Value::Set(ValueSet)newtype that cannot nest;Valuebecomes#[non_exhaustive]; prepared queries useBindValue::Val.collect-setis the[?e :a ?v]pattern per row,#{}when empty, allowed wherever an expression clause is.Delivery: 3 PRs into
v3(values, predicates,collect-set), then the docs site and one PR per binding. Error codes PRS-119–122, QRY-014, API-021 are tentative (next free at PR time; #306 holds PRS-115–118).Refs #316
🤖 Generated with Claude Code
https://claude.ai/code/session_01TcpoiFyFeQQQELL872LfQF