Repository navigation
docs(spec): :limit, :offset and :order-by (#306) - #729
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169pNQsLcCEn48te9X9WuZW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169pNQsLcCEn48te9X9WuZW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169pNQsLcCEn48te9X9WuZW
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design spec for #306:
docs/superpowers/specs/2026-10-24-limit-order-by-design.md.Decisions (approved 2026-10-24):
:order-byadded, with aSortoperator keeping the topoffset + limitrows under a:limit.:limitwithout:order-byreturns anynrows of the answer and stops pulling early; the one documented exception to plan-independent answers (always a sub-bag).:offsetwithout:order-byis rejected at parse (PRS-116).:order-bynames:findelements, aggregates and windows included; ties broken by the remaining:findcolumns (value_order), so ordered results are fully determined.New codes PRS-115–118; no format, WAL or public-API change. Delivery: PR 1
:limit, PR 2:order-by/:offset+ docs site. Includes the 10M-fact:limitacceptance test moved from #473.Reviewed with Codex; its four findings (typed slot resolution, verifier tokens/witnesses, early-stop scope under blocking operators,
keep = 0) are fixed in the second commit.Part of #306 (stays open until PR 2).
🤖 Generated with Claude Code
https://claude.ai/code/session_0169pNQsLcCEn48te9X9WuZW