Repository navigation
perf(query): fix O(n²) contains_fact in semi-naive evaluation (issue #29) - #72
Merged
Merged
Conversation
Issue: contains_fact iterates through all seen facts for each new fact, making total complexity O(n²) in semi-naive evaluation. Fix: Use BTreeSet with canonical value encoding as key. - Replace Vec<(Uuid, String, Value)> with BTreeSet<(Uuid, String, Vec<u8>)> - Use encode_value() to convert Value to canonical bytes - Complexity reduced from O(n²) to O(n log n) - Removed now-unused contains_fact method
Closed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vec + linear scanwithBTreeSetfor tracking seen factsencode_value()to convertValueto canonical bytes as the keycontains_factmethod