8000 perf(query): fix O(n²) aggregation grouping (issue #31) by adityamukho · Pull Request #71 · project-minigraf/minigraf · GitHub
[go: up one dir, main page]
Skip to content

perf(query): fix O(n²) aggregation grouping (issue #31) #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityamukho merged 1 commit into from
Apr 3, 2026
Merged

perf(query): fix O(n²) aggregation grouping (issue #31) #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/query/datalog/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,18 +791,15 @@ fn compute_aggregation(
group_var_names.extend(with_vars.iter().map(|s| s.as_str()));
}

// Group using Vec + PartialEq scan (Value::Float doesn't implement Hash).
let mut groups: Vec<(Vec<Value>, Vec<Binding>)> = Vec::new();
// Group using BTreeMap keyed by group key (O(log g) instead of O(g) per binding).
use std::collections::BTreeMap;
let mut groups: BTreeMap<Vec<Value>, Vec<Binding>> = BTreeMap::new();
for b in bindings {
let key: Vec<Value> = group_var_names
.iter()
.map(|v| b.get(*v).cloned().unwrap_or(Value::Null))
.collect();
if let Some(pos) = groups.iter().position(|(k, _)| k == &key) {
groups[pos].1.push(b);
} else {
groups.push((key.clone(), vec![b]));
}
groups.entry(key).or_default().push(b);
}

// Build a position map for Variable specs only (indices 0..n_vars in the key vector).
Expand All @@ -821,7 +818,7 @@ fn compute_aggregation(
}

let mut results: Vec<Binding> = Vec::new();
for (key, group_bindings) in &groups {
for (key, group_bindings) in groups.iter() {
let mut binding = Binding::new();
let mut skip = false;

Expand Down
Loading
0