Repository navigation
ci(crash-kill): run v3's nightly rounds with test-oracle (#687) - #695
Merged
Merged
Conversation
Scheduled workflows run the copy on the default branch, so v3's --features test-oracle change (#685) never reached the nightly v3 run and its Large variant (#550) did not run. Land v3's crash-kill.yml on main unchanged; main has no test-oracle feature and keeps its command. Closes #687 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT
A dispatch on a main-based ref other than main would have passed a feature that does not exist there; a v3-based branch keeps the variant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 task
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scheduled workflows run the copy of the file on the default branch, so #685's change to
crash-kill.ymlonv3never reached the nightly v3 run (cron17 15 * * *), and theLargecrash-kill variant (#550) did not run nightly.This lands
v3'scrash-kill.ymlonmain, with one change (from Codex review, mirrored onv3in the companion PR):--features test-oracleis passed when the checked-outCargo.tomldefines the feature, not when the ref is notmain. Aworkflow_dispatchon a main-based branch would otherwise pass a feature that does not exist.mainhas notest-oracle, so its command is unchanged. The failure report's "Reproduce" line notes the flag.Closes #687
Test plan
workflow_dispatchwithref: v3shows theLargevariant's rounds on all three OSes.🤖 Generated with Claude Code
https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT