Repository navigation
ci(v3): binary-size gate report-only until #551 - #680
Merged
Merged
Conversation
#549 PR 1 (#676) left the release binary at 1259 of 1260 KiB with #549 PR 2, #550 and #551 still to land while the engine and the executor both ship. The check still builds and prints the size and warns above the limit; it no longer fails. It returns to an enforced 1200 KiB when #551 removes the executor's query path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
v3binary-size check report-only, temporarily.#549 PR 1 (#676) left the release binary at 1,259 of 1,260 KiB, with #549 PR 2, #550 and #551 still to land while the streaming engine and the old executor both ship.
binary-size.ymlonv3still builds the release binary and prints its size. Above the 1,260 KiB limit it emits a::warning::instead of failing (SIZE_GATE: report).PHILOSOPHY.md§4 says the same.SIZE_GATEback tofailwithSIZE_LIMIT_BYTES: 1228800(1,200 KiB).mainis unchanged: its gate stays enforced.🤖 Generated with Claude Code
https://claude.ai/code/session_019kY61Y11gcRD91Y6b7jbGT