Repository navigation
fix(query): pre-compile regex patterns at parse time (issue #36) - #67
Merged
Merged
Conversation
Issue: regex was compiled on every match evaluation in executor.rs - Modified BinOp::Matches to hold pre-compiled regex + pattern string - Updated parser to compile regex at parse time (after validation) - Updated executor to use pre-compiled regex directly - Added manual PartialEq/Eq/Hash impls for BinOp (regex doesn't impl these)
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (59.25%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 84.38% 84.21% -0.18%
==========================================
Files 25 25
Lines 4374 4390 +16
==========================================
+ Hits 3691 3697 +6
- Misses 683 693 +10
🚀 New features to boost your workflow:
|
Closed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BinOp::Matchesto hold a pre-compiledregex_lite::Regex+ pattern string for equality/hashingparse_expreval_binopThis fixes the performance issue where regex was being compiled for every binding evaluation during query execution.