Repository navigation
docs(grammar): document line comments and Unicode identifiers (#650) - #660
Merged
Merged
Conversation
Backport of #658 from v3. grammar.pest skips `;` line comments like whitespace, and symbols, variables, keywords and bind slots use ALPHABETIC and NUMBER, as the tokenizer does; `-` followed by a numeral is a number, not a symbol. The verifier's Comment and UnicodeLetter drift entries are removed. No parser change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #658 (v3) to main.
tests/grammar/grammar.pestnow describes what the v2.x parser has always accepted:;line comments, and Unicode letters and numerals (ALPHABETIC/NUMBER) in symbols, variables, keywords and bind slots, with-+ numeral read as a number. The verifier'sCommentandUnicodeLetterKNOWN_DRIFTentries are removed. No parser change. CHANGELOG, CLAUDE.md and TEST_COVERAGE updated; test count unchanged (main has nogrammar_doctest).The docs site's hand-written v2 EBNF gets the same change in a separate minigraf-docs PR.
Verification
cargo test --lib verifier: 4 passed.cargo test --test grammar_conformance,cargo clippy -- -D warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz