Repository navigation
perf(query): optimize CountDistinct/SumDistinct from O(n²) to O(n log n) - #66
Merged
Merged
Conversation
- Add Eq, PartialOrd, Ord implementations to Value enum for sorting - Replace Vec.contains O(n) deduplication with sorting + dedup O(n log n) - This improves performance significantly for large groups Closes #50
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 84.79% 84.38% -0.41%
==========================================
Files 25 25
Lines 4353 4374 +21
==========================================
Hits 3691 3691
- Misses 662 683 +21
🚀 New features to boost your workflow:
|
adityamukho
added a commit
that referenced
this pull request
Apr 3, 2026
…or Value Value::Ord's cross-variant fallthrough compared stack-frame pointer addresses, which is non-deterministic across call contexts and violates Rust's Ord contract (BTreeMap/BTreeSet require a consistent total order). This caused incorrect aggregation grouping (PR #71) and wrong OR/OrJoin deduplication (PR #68). Fix: use a stable u8 discriminant per variant for cross-variant ordering. Also fix the O(n²) Vec::contains deduplication in count-distinct and sum-distinct (issue #50, which PR #66 claimed to fix but did not): replace with BTreeSet, which is now safe because Value::Ord is a correct total order. Adds two regression tests: - value_ord_cross_variant_is_antisymmetric: proves the old code violated antisymmetry (cmp(a,b) must equal reverse(cmp(b,a))) - value_ord_cross_variant_is_stable: cross-variant ordering must depend only on the variant type, not the inner value Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eq,PartialOrd, andOrdimplementations toValueenum for sorting supportVec.containsO(n) deduplication with sorting + dedup O(n log n)Fixes #50 - CountDistinct/SumDistinct was O(n²) due to Vec.contains.