8000 docs(spec): aggregation and window functions on the streaming engine (#547) by adityamukho · Pull Request #640 · project-minigraf/minigraf · GitHub
[go: up one dir, main page]

Skip to content

docs(spec): aggregation and window functions on the streaming engine (#547) - #640

Merged
adityamukho merged 1 commit into
v3from
feat/547-aggregate
Oct 20, 2026
Merged

adityamukho merged 1 commit into
v3from
feat/547-aggregate

Conversation

@adityamukho
Copy link
Copy Markdown
Collaborator

Design for #547 (part 5 of 9 of #473). Docs only.

Decisions settled 2026-10-20:

  1. Window ties are SQL peers: running aggregates give every peer the value at the last peer, rank is equal for peers, row-number breaks ties by the other :find-named variables. One total value order for sorting, peers, rank and window min/max.
  2. Exact sums: integers in i128 saturated once, floats summed exactly and rounded once; one accumulator module for engine and executor.
  3. Index-order Sort skip and sort-grouped Aggregate deferred to a follow-up with No working result-limiting/pagination mechanism for plain (non-recursive) :find queries #306.
  4. A window in an aggregate query reading a non-grouping variable fails with new PRS-082.

Breaking answer changes for v3.0.0 are listed in §3.4. Delivery: three PRs (rules on the executor, Aggregate on the engine, Window on the engine).

Reviewed with Codex; its findings (float special cases, deferred errors, peer vs group equality, tie-break variables in aggregate queries, PRS-082 wording) are addressed.

Part of #473 (no closing keyword).

🤖 Generated with Claude Code

https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz

…547)

Settled 2026-10-20: SQL peers for window ties with one total value
order, exact sums shared by both engines, index-order tricks deferred
to #306, PRS-082 for a window reading a non-grouping variable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PtCdzbJMSS1V8qEPaJ4jXz
@codecov
codecov Bot commented Oct 20, 2026
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@adityamukho
adityamukho merged commit 2122d15 into v3 Oct 20, 2026
25 checks passed
@adityamukho
adityamukho d 84D4 eleted the feat/547-aggregate branch October 20, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0