Repository navigation
docs: design for not, not-join and or on the streaming engine (#546) - #614
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HyLscCUuJ1GQpdAeX79EdR
…ime in bodies Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HyLscCUuJ1GQpdAeX79EdR
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design for #546 (part 4 of 9 of #473):
AntiJoin(hash or correlated) fornot/not-join,Union+Distinctforor/or-join, and one comparison rule (#545 join equality) inside bodies and branches on the executor too.Decisions settled 2026-10-16: two PRs (not, then or); join equality everywhere; correlated bodies on the engine;
orkeeps today's placement and dedup.Answer changes found while writing it (§3.6), reproduced on
v3:not-joinbody matches withinf64::EPSILONonly when the body has an expression;:db/valid-atin anot-joinbody readsnilwhen the body has an expression (evaluate_not_joinusesPatternMatcher::from_slice).Docs only. Part of #473 (no closing keyword).
🤖 Generated with Claude Code
https://claude.ai/code/session_01HyLscCUuJ1GQpdAeX79EdR